Abandoned Element Changer 2nd weapon not loading

[Caves]

Hi guys it's me again with another help thread.
Here's what I'm having trouble with today.

Source: Eternium Source
Base: Clean V19.4

I copied a Quick Element Change feature from Eternium Source. Everything else works except for the 2nd weapon showing up when its for the blade Class.
So... I did some changes to the code to make it work for the blade class's 2nd weapon but now whenever I wear a shield it not showing up.
At this point, changing the two different weapon's element works. But when I wear a shield even when a different class, the shield doesnt show up.

Please login and(or) register to see this awesome content today.

Here's what I did:

Please login and(or) register to see this awesome content today.

Please login and(or) register to see this awesome content today.

I was wondering if I was doing it the right way or if there is another way thats more simpler than what I thought

 

[devious]

if (pLWeapon && PARTS_SHIELD)

if (pLWeapon != nullptr && PARTS_SHIELD)

You are checking if "#define PARTS_SHIELD 11"

 

[Caves]

You are checking if "#define PARTS_SHIELD 11"

Please login and(or) register to see this awesome content today.

I think thats what you are pertaining to.
I changed it back to "pLWeapon->GetProp()"

 

[devious]

Also you are checking in your if statement
if #define JOB_BLADE_MASTER 17
if #define JOB_BLADE_HERO 25

which will always return true since they are defined more than 0

How to Add Multiple Conditions for if Statement in C++? - GeeksforGeeks

A Computer Science portal for geeks. It contains well written, well thought and well explained computer science and programming articles, quizzes and practice/competitive programming/company interview Questions.

www.geeksforgeeks.org

 

[Caves]

Oh, I just realized that Shields dont have elements. LOL

But I'll add the option to add it with this snippet:

Snippet Thread 'Shield Elementing'

Jun 12, 2024

This allows shields to have elements.

Define:

Please login and(or) register to see this awesome content today.

Item.cpp

Please login and(or) register to see this awesome content today.

• zOmbie
• Replies: 0
• Forum: Knowledge

 

[Caves]

Its working now. Thank you!
I guess I almost already had it and the only thing not making it work was not enabling Shield elements.

Silly me, anyway thank you to everyone that help and to @devious you gave tips/hints.



Edit: Here's the final code:

Please login and(or) register to see this awesome content today.

Let me know if there are better ways to improve the code. I'm still learning.

 

[devious]

The if statement where you are supposedly checking players job is still not right, might aswell just remove it as it is irrelevant.